Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error adding nodes to nano import-cluster with cni limit #330

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

zhuzhenfan
Copy link
Contributor

@zhuzhenfan zhuzhenfan commented Nov 3, 2022

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Error adding nodes to nano import-cluster with cni limit. We usually think of cluster add/remove nodes as not necessarily related to cni

Which issue(s) this PR fixes:

Fixes #329

Special notes for reviewers:

@x893675 @qinyer 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #330 (f00f215) into master (36da26a) will decrease coverage by 0.02%.
The diff coverage is 16.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage   12.96%   12.94%   -0.03%     
==========================================
  Files         102      102              
  Lines       15647    15649       +2     
==========================================
- Hits         2028     2025       -3     
- Misses      13376    13382       +6     
+ Partials      243      242       -1     
Impacted Files Coverage Δ
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)
pkg/scheme/core/v1/k8s/node.go 0.34% <0.00%> (-0.01%) ⬇️
pkg/apis/core/v1/schema.go 70.28% <100.00%> (+0.55%) ⬆️

Signed-off-by: zhuzhenfan <981189503@qq.com>
@zhuzhenfan zhuzhenfan changed the title fix: Error adding nodes to nano cluster with cni limit fix: Error adding nodes to nano import-cluster with cni limit Nov 3, 2022
@qinyer
Copy link
Contributor

qinyer commented Nov 3, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 4567d52b69fbdc684e9992eb34edb8c3fdc413da

@x893675
Copy link
Collaborator

x893675 commented Nov 3, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@kubeclipper-bot kubeclipper-bot merged commit d551acc into kubeclipper:master Nov 3, 2022
@zhuzhenfan zhuzhenfan deleted the cni branch November 14, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error adding nodes to nano import-cluster with cni limit
5 participants