-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The backup name is not the same as the backup file name #331
Conversation
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 12.96% 12.96%
=======================================
Files 102 102
Lines 15647 15647
=======================================
Hits 2028 2028
Misses 13376 13376
Partials 243 243
|
@@ -1171,7 +1171,7 @@ func (h *handler) CreateBackup(request *restful.Request, response *restful.Respo | |||
randNum := r.String(6) | |||
backup.Name = fmt.Sprintf("%s-%s-%s", c.Name, backup.Name, randNum) | |||
backup.Status.KubernetesVersion = c.KubernetesVersion | |||
backup.Status.FileName = fmt.Sprintf("%s-%s", c.Name, backup.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe need deal with cornBackup too
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
/lgtm |
LGTM label has been added. Git tree hash: a87ca1198096f138d40b0d75a3d9ee5a4c371e47
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Metrora, x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Liucw liu.chuwei@99cloud.net
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #328
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@zhuzhenfan @x893675