ci: add e2e test workflow #333

cmycoups · 2022-11-03T07:51:57Z

No description provided.

kubeclipper-bot · 2022-11-03T07:52:00Z

@cmycoups: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wu-wenxiang · 2022-11-03T08:01:58Z

.github/workflows/aio.yaml

+      - name: update kcctl
+        run: sudo cp ./dist/kcctl /usr/local/bin/
+      - name: update kc-server
+        run: |
+          sudo systemctl stop kc-server
+          sudo cp ./dist/kubeclipper-server /usr/local/bin/
+          sudo systemctl start kc-server
+      - name: update kc-agent
+        run: |
+          sudo systemctl stop kc-agent
+          sudo cp ./dist/kubeclipper-agent /usr/local/bin/
+          sudo systemctl start kc-agent


合并一下，一起停掉，替换好，再一起开，这样干净，不会有残留数据，比如历史的 agent 数据上报到新的 server

- name: update kc assembly run: | sudo cp ./dist/kcctl /usr/local/bin/ sudo systemctl stop kc-agent sudo systemctl stop kc-server sudo cp ./dist/kubeclipper-agent /usr/local/bin/ sudo cp ./dist/kubeclipper-server /usr/local/bin/ sudo systemctl start kc-agent sudo systemctl start kc-server

wu-wenxiang · 2022-11-03T08:03:20Z

.github/workflows/aio.yaml

+          sudo systemctl start kc-agent
+      - name: login
+        run: |
+          sudo sleep 20s


不要 sudo，暂时 sleep 20 可以，后续可以想办法优化

x893675 · 2022-11-03T08:28:00Z

/kind workflow
/area testing

x893675 · 2022-11-03T08:28:49Z

help review first. /cc @lixd

x893675 · 2022-11-03T08:29:36Z

/retitle ci: add e2e test workflow

x893675 · 2022-11-03T08:31:40Z

/cc @lixd

x893675 · 2022-11-03T08:32:07Z

/milestone v1.3.1

codecov-commenter · 2022-11-03T08:52:24Z

Codecov Report

Merging #333 (8bfbbfb) into master (36da26a) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   12.96%   12.88%   -0.08%     
==========================================
  Files         102      102              
  Lines       15647    15717      +70     
==========================================
- Hits         2028     2025       -3     
- Misses      13376    13450      +74     
+ Partials      243      242       -1

Impacted Files	Coverage Δ
pkg/scheme/core/v1/k8s/node.go	`0.34% <0.00%> (-0.01%)`	⬇️
pkg/apis/core/v1/handler.go	`0.30% <0.00%> (-0.01%)`	⬇️
pkg/scheme/core/v1/k8s/kubeadm_step.go	`0.00% <0.00%> (ø)`
pkg/apis/core/v1/schema.go	`70.28% <0.00%> (+0.55%)`	⬆️

wu-wenxiang · 2022-11-03T08:37:25Z

.github/workflows/aio.yaml

+          sudo systemctl stop kc-server
+          sudo cp ./dist/kubeclipper-agent /usr/local/bin/
+          sudo cp ./dist/kubeclipper-server /usr/local/bin/
+          sudo systemctl start kc-agent


启动顺序要反过来，先启动 server，再 agent

kubeclipper-bot · 2022-11-03T13:16:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmycoups, wu-wenxiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wu-wenxiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wu-wenxiang · 2022-11-03T13:21:05Z

/lgtm

kubeclipper-bot · 2022-11-03T13:21:11Z

LGTM label has been added.

Git tree hash: 1c6d6b9c9abbf7d7420b3ca2a0dbbe54d92423bf

x893675 · 2022-11-04T01:55:25Z

/remove-approve

x893675 · 2022-11-04T01:56:20Z

/approve cancel

x893675 · 2022-11-04T01:57:50Z

/remove approve

x893675 · 2022-11-04T02:06:11Z

.github/workflows/aio.yaml

@@ -0,0 +1,83 @@
+name: test


rename file aio to e2e-aio
rename job name test to e2e-aio-test

x893675 · 2022-11-04T02:06:36Z

.github/workflows/aio.yaml

+on:
+  push:
+    branches:
+      - 'master'


pull request

lixd · 2022-11-04T02:08:59Z

.github/workflows/aio.yaml

+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Get branch name


uncessary step

wu-wenxiang · 2022-11-04T03:09:47Z

/lgtm

kubeclipper-bot · 2022-11-04T03:09:52Z

LGTM label has been added.

Git tree hash: 1c6d6b9c9abbf7d7420b3ca2a0dbbe54d92423bf

x893675 · 2022-11-04T05:35:14Z

/revert

This reverts commit 2ccb656.

This reverts commit 2ccb656. Signed-off-by: x893675 <x893675@icloud.com>

This reverts commit 2ccb656. Signed-off-by: x893675 <x893675@icloud.com> Signed-off-by: x893675 <x893675@icloud.com>

kubeclipper-bot added dco-signoff: no do-not-merge/release-note-label-needed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022

wu-wenxiang requested changes Nov 3, 2022

View reviewed changes

cmycoups force-pushed the master branch from e1e74d7 to 7eb8c1c Compare November 3, 2022 08:26

kubeclipper-bot added dco-signoff: yes and removed dco-signoff: no labels Nov 3, 2022

kubeclipper-bot added kind/workflow add github workflow area/testing Categorizes issue or PR as related to testing. labels Nov 3, 2022

kubeclipper-bot changed the title ~~feat: add deploy check in workflow~~ ci: add e2e test workflow Nov 3, 2022

kubeclipper-bot requested a review from lixd November 3, 2022 08:31

kubeclipper-bot added this to the v1.3.1 milestone Nov 3, 2022

x893675 mentioned this pull request Nov 3, 2022

feat: add deploy check in workflow #300

Closed

cmycoups force-pushed the master branch from 7eb8c1c to 01c6944 Compare November 3, 2022 08:42

kubeclipper-bot added dco-signoff: no and removed dco-signoff: yes labels Nov 3, 2022

cmycoups force-pushed the master branch from b7ad3c7 to 01c6944 Compare November 3, 2022 09:02

kubeclipper-bot added dco-signoff: yes dco-signoff: no and removed dco-signoff: no dco-signoff: yes labels Nov 3, 2022

cmycoups force-pushed the master branch from 98dc998 to 01c6944 Compare November 3, 2022 09:24

kubeclipper-bot removed the dco-signoff: no label Nov 3, 2022

wu-wenxiang approved these changes Nov 3, 2022

View reviewed changes

kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022

kubeclipper-bot assigned wu-wenxiang Nov 3, 2022

kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022

kubeclipper-bot added dco-signoff: no and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes labels Nov 3, 2022

x893675 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022

x893675 reviewed Nov 4, 2022

View reviewed changes

.github/workflows/aio.yaml

@@ -0,0 +1,83 @@

name: test

Copy link

Collaborator

x893675 Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file aio to e2e-aio
rename job name test to e2e-aio-test

x893675 reviewed Nov 4, 2022

View reviewed changes

.github/workflows/aio.yaml

on:

push:

branches:

- 'master'

Copy link

Collaborator

x893675 Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull request

cmycoups force-pushed the master branch from 8bfbbfb to 4542b87 Compare November 4, 2022 02:07

kubeclipper-bot added dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed dco-signoff: no labels Nov 4, 2022

lixd reviewed Nov 4, 2022

View reviewed changes

.github/workflows/aio.yaml

uses: actions/checkout@v2

with:

fetch-depth: 0

- name: Get branch name

Copy link

Contributor

lixd Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncessary step

kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022

kubeclipper-bot merged commit 2ccb656 into kubeclipper:master Nov 4, 2022

x893675 added a commit that referenced this pull request Nov 4, 2022

Revert "feat: add deploy check in workflow (#333)"

4ba6b53

This reverts commit 2ccb656.

x893675 mentioned this pull request Nov 4, 2022

Revert "ci: add e2e test workflow" #337

Merged

x893675 added a commit that referenced this pull request Nov 4, 2022

Revert "feat: add deploy check in workflow (#333)"

a244ea3

This reverts commit 2ccb656. Signed-off-by: x893675 <x893675@icloud.com>

kubeclipper-bot pushed a commit that referenced this pull request Nov 4, 2022

Revert "feat: add deploy check in workflow (#333)" (#337)

da2b37b

This reverts commit 2ccb656. Signed-off-by: x893675 <x893675@icloud.com> Signed-off-by: x893675 <x893675@icloud.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add e2e test workflow #333

ci: add e2e test workflow #333

cmycoups commented Nov 3, 2022

kubeclipper-bot commented Nov 3, 2022

wu-wenxiang Nov 3, 2022

wu-wenxiang Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

codecov-commenter commented Nov 3, 2022 •

edited

wu-wenxiang Nov 3, 2022

kubeclipper-bot commented Nov 3, 2022

wu-wenxiang commented Nov 3, 2022

kubeclipper-bot commented Nov 3, 2022

x893675 commented Nov 4, 2022

x893675 commented Nov 4, 2022

x893675 commented Nov 4, 2022

x893675 Nov 4, 2022

x893675 Nov 4, 2022

lixd Nov 4, 2022

wu-wenxiang commented Nov 4, 2022

kubeclipper-bot commented Nov 4, 2022

x893675 commented Nov 4, 2022

ci: add e2e test workflow #333

ci: add e2e test workflow #333

Conversation

cmycoups commented Nov 3, 2022

kubeclipper-bot commented Nov 3, 2022

wu-wenxiang Nov 3, 2022

Choose a reason for hiding this comment

wu-wenxiang Nov 3, 2022

Choose a reason for hiding this comment

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

x893675 commented Nov 3, 2022

codecov-commenter commented Nov 3, 2022 • edited

Codecov Report

wu-wenxiang Nov 3, 2022

Choose a reason for hiding this comment

kubeclipper-bot commented Nov 3, 2022

wu-wenxiang commented Nov 3, 2022

kubeclipper-bot commented Nov 3, 2022

x893675 commented Nov 4, 2022

x893675 commented Nov 4, 2022

x893675 commented Nov 4, 2022

x893675 Nov 4, 2022

Choose a reason for hiding this comment

x893675 Nov 4, 2022

Choose a reason for hiding this comment

lixd Nov 4, 2022

Choose a reason for hiding this comment

wu-wenxiang commented Nov 4, 2022

kubeclipper-bot commented Nov 4, 2022

x893675 commented Nov 4, 2022

codecov-commenter commented Nov 3, 2022 •

edited