Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import cluster fix: Backup point reset / missing etcdctl / recovery r… #339

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

zhuzhenfan
Copy link
Contributor

@zhuzhenfan zhuzhenfan commented Nov 4, 2022

…eboot prompt exception / kubeadm join signature problem

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. nano cluster, the backup point will be reset because of the synchronization cycle
  2. nano cluster, not imported etcdctl, resulting in the inability to backup
  3. nano cluster, unsupported cni, restore restart prompt exception (code has null pointer)
  4. apiserver.local join signature problem when adding node join in nano cluster

Which issue(s) this PR fixes:

Fixes #338

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @lixd

@kubeclipper-bot
Copy link
Collaborator

@zhuzhenfan: The label(s) kind/bu cannot be applied, because the repository doesn't have them.

In response to this:

…eboot prompt exception / kubeadm join signature problem

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bu

What this PR does / why we need it:

  1. nano cluster, the backup point will be reset because of the synchronization cycle
  2. nano cluster, not imported etcdctl, resulting in the inability to backup
  3. nano cluster, unsupported cni, restore restart prompt exception (code has null pointer)
  4. apiserver.local join signature problem when adding node join in nano cluster

Which issue(s) this PR fixes:

Fixes #338

Special notes for reviewers:

@x893675 @lixd 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added release-note-none dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2022
@@ -42,23 +42,26 @@ type Kubeadm struct {
Operator clustermanage.Operator
Provider v1.CloudProvider
Config Config
KubeCli kubernetes.Clientset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename clientset

…eboot prompt exception / kubeadm join signature problem

Signed-off-by: zhuzhenfan <981189503@qq.com>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 470ad07ab6c2c1357b913946f07a1b3b7b5e22c7

@x893675
Copy link
Collaborator

x893675 commented Nov 4, 2022

/lgtm
/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@kubeclipper-bot kubeclipper-bot merged commit 97676ec into kubeclipper:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
4 participants