fix: Backup points cannot be deleted when in use #34
Conversation
|
@Xvv-v: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeclipper-bot
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
- Coverage 11.50% 11.49% -0.02%
==========================================
Files 92 92
Lines 14201 14217 +16
==========================================
Hits 1634 1634
- Misses 12350 12366 +16
Partials 217 217
|
|
/cc @x893675 |
pkg/apis/core/v1/utils.go
Outdated
| @@ -363,3 +364,12 @@ func getActBackupStep(c *v1.Cluster, b *v1.Backup, bp *v1.BackupPoint, pNode *v1 | |||
|
|
|||
| return actBackup.GetStep(action), nil | |||
| } | |||
|
|
|||
| func (h *handler) getBackupPoint(backups *v1.BackupList, name string) bool { | |||
There was a problem hiding this comment.
update func name “existBackupPoint”
There was a problem hiding this comment.
I think maybe it would be better to change it to inUsed.
kubeclipper-bot
added
dco-signoff: yes
needs-rebase
size/XXL
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
kubeclipper-bot
added
size/M
Signed-off-by: Xvv-v <xu.jingwen@99cloud.net>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 8791def003eeb1949e3880be816892966ca96696
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, Xvv-v The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
the
approved
Signed-off-by: Xvv-v xu.jingwen@99cloud.net
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: