Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed to create one master one worker cluster with component without specifying the registry #356

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Nov 9, 2022

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #355

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@zhuzhenfan @x893675

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2022
@Metrora Metrora changed the title fix: Failed to create one master one worker cluster with component fix: Failed to create one master one worker cluster with component without specifying the registry Nov 9, 2022
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #356 (7c71b58) into master (d0f93c2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   12.87%   12.87%           
=======================================
  Files         102      102           
  Lines       15734    15734           
=======================================
  Hits         2025     2025           
  Misses      13467    13467           
  Partials      242      242           
Impacted Files Coverage Δ
pkg/component/nfs/nfs.go 0.56% <0.00%> (ø)

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1e32a14ce96dde13893f5c8c93ed630879984b92

@x893675
Copy link
Collaborator

x893675 commented Nov 10, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@kubeclipper-bot kubeclipper-bot merged commit a31132a into kubeclipper:master Nov 10, 2022
@Metrora Metrora deleted the dev branch November 10, 2022 04:10
@zhuzhenfan
Copy link
Contributor

/reopen

@kubeclipper-bot
Copy link
Collaborator

@zhuzhenfan: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhuzhenfan zhuzhenfan mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create one master one worker cluster with component without specifying the registry
5 participants