Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the code of month-end cronbackup #379

Merged
merged 1 commit into from
Nov 14, 2022
Merged

update the code of month-end cronbackup #379

merged 1 commit into from
Nov 14, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Nov 14, 2022

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #365

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@zhuzhenfan @x893675

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #379 (fe10a8f) into master (50c9254) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   12.26%   12.26%   -0.01%     
==========================================
  Files         102      102              
  Lines       16853    16851       -2     
==========================================
- Hits         2067     2066       -1     
+ Misses      14539    14538       -1     
  Partials      247      247              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.32% <0.00%> (+<0.01%) ⬆️
pkg/controller/cronbackupcontroller/controller.go 2.22% <50.00%> (-0.25%) ⬇️

@x893675
Copy link
Collaborator

x893675 commented Nov 14, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f6c50e803560b9e357b6b4d1bd27b8edb930bce1

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@x893675
Copy link
Collaborator

x893675 commented Nov 14, 2022

/cherrypick release-1.3

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #381

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Metrora Metrora deleted the dev branch November 14, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The month-end cronbackup cannot be edited
4 participants