-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The imported cluster is missing the kubectl terminal image #397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 12.23% 12.17% -0.06%
==========================================
Files 102 103 +1
Lines 16890 16969 +79
==========================================
Hits 2066 2066
- Misses 14577 14656 +79
Partials 247 247
|
Signed-off-by: zhuzhenfan <981189503@qq.com>
/lgtm |
LGTM label has been added. Git tree hash: dc8ac876bb7ab9deafe3fa11dce9f7845d32f382
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675, zhuzhenfan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.3 |
@x893675: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@x893675: new pull request created: #401 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@zhuzhenfan: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: zhuzhenfan 981189503@qq.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
The imported cluster is missing the kubectl terminal image, which prevents the service from starting
Which issue(s) this PR fixes:
Fixes #396
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
@x893675 @lixd