Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cluster cert update e2e test #423

Merged
merged 1 commit into from
Nov 25, 2022
Merged

test: add cluster cert update e2e test #423

merged 1 commit into from
Nov 25, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Nov 24, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

@lixd
test: add cluster cert update e2e test
f34e7cf 
Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot
Copy link
Collaborator

@lixd: The label(s) kind/, kind/test cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added release-note-none dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #423 (f34e7cf) into master (d21cca6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   12.10%   12.10%           
=======================================
  Files         109      109           
  Lines       17596    17596           
=======================================
  Hits         2130     2130           
  Misses      15217    15217           
  Partials      249      249

@lixd
Copy link
Contributor Author

lixd commented Nov 24, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Nov 25, 2022

/lgtm
/approve
/cherrypick release-1.3

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: cebad80d97fa45972aa4d46dbd25bfed112c2fe2

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@kubeclipper-bot kubeclipper-bot merged commit 4b58042 into kubeclipper:master Nov 25, 2022
@kubeclipper-bot kubeclipper-bot mentioned this pull request Nov 25, 2022
Closed
@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #428

In response to this:

/lgtm
/approve
/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lixd added a commit to lixd/kubeclipper that referenced this pull request Nov 25, 2022
@lixd
test: add cluster cert update e2e test (kubeclipper#423)
4c47fa7 
Signed-off-by: lixd <xueduan.li@gmail.com>

Signed-off-by: lixd <xueduan.li@gmail.com>
(cherry picked from commit 4b58042)
lixd added a commit to lixd/kubeclipper that referenced this pull request Nov 25, 2022
@lixd
test: add cluster cert update e2e test (kubeclipper#423)
dbd29e6 
Signed-off-by: lixd <xueduan.li@gmail.com>

(cherry picked from commit 4b58042)
kubeclipper-bot pushed a commit that referenced this pull request Nov 25, 2022
@lixd
test: add cluster cert update e2e test (#423) (#432)
836e5e4 
Signed-off-by: lixd <xueduan.li@gmail.com>

(cherry picked from commit 4b58042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@x893675 x893675

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lixd @kubeclipper-bot @codecov-commenter @x893675