Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri registry e2e test #433

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Nov 25, 2022

Signed-off-by: qinyer qy913726062@gmail.com

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #431

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #433 (8544fb3) into release-1.3 (836e5e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #433   +/-   ##
============================================
  Coverage        12.85%   12.85%           
============================================
  Files              103      103           
  Lines            15843    15843           
============================================
  Hits              2036     2036           
  Misses           13562    13562           
  Partials           245      245           

@x893675 x893675 changed the title cri registry e2e test (#424) cri registry e2e test Nov 25, 2022
@x893675 x893675 linked an issue Nov 25, 2022 that may be closed by this pull request
Signed-off-by: qinyer <qy913726062@gmail.com>
@x893675
Copy link
Collaborator

x893675 commented Nov 25, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: b0c8ba5f26d64674bdcf69b59f8524254d06da73

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@kubeclipper-bot kubeclipper-bot merged commit cdc12c9 into kubeclipper:release-1.3 Nov 25, 2022
@qinyer qinyer deleted the release-1.3 branch November 29, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release-1.3] cri registry e2e test
4 participants