Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the K8S mirror proxy setting option #49

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Jul 28, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #47

Special notes for reviewers:

Does this PR introduced a user-facing change?

1. When you run the KCCTL quick installation script, you can set the KC_REGION environment variable in advance. The script dynamically generates the repo mirror env file based on the value of the variable.
2. Currently supported KC_REGION=cn, then the script automatically sets the third-party repo mirror proxy.
3. Users can set KC_IMAGE_REPO_MIRROR variable to customize the third-party repo mirror proxy.

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2022
@qinyer
Copy link
Contributor Author

qinyer commented Jul 28, 2022

/assign @x893675

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #49 (b5d2e92) into master (5310326) will increase coverage by 0.00%.
The diff coverage is 14.28%.

❗ Current head b5d2e92 differs from pull request most recent head 97127d6. Consider uploading reports for the commit 97127d6 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   11.49%   11.49%           
=======================================
  Files          92       92           
  Lines       14217    14224    +7     
=======================================
+ Hits         1634     1635    +1     
- Misses      12366    12372    +6     
  Partials      217      217           
Impacted Files Coverage Δ
pkg/cli/join/join.go 0.00% <0.00%> (ø)
pkg/scheme/core/v1/k8s/kubeadm.go 1.05% <0.00%> (-0.01%) ⬇️
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)
pkg/cli/deploy/deploy.go 16.15% <100.00%> (+0.12%) ⬆️

@kubeclipper-bot kubeclipper-bot added needs-rebase dco-signoff: no size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed dco-signoff: yes needs-rebase size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@kubeclipper-bot kubeclipper-bot added dco-signoff: yes needs-rebase size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed dco-signoff: no size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2022
@kubeclipper-bot kubeclipper-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2022
@kubeclipper-bot kubeclipper-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
@qinyer qinyer force-pushed the feat-cn-k8s-online branch 2 times, most recently from 4525209 to 7a1f9df Compare August 1, 2022 10:38
Signed-off-by: qinyer <qy913726062@gmail.com>
@x893675
Copy link
Collaborator

x893675 commented Aug 2, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: dc267b0e86f0c4f726adc79510ed8c7adafe2bca

@x893675
Copy link
Collaborator

x893675 commented Aug 2, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@kubeclipper-bot kubeclipper-bot merged commit a9878e9 into kubeclipper:master Aug 2, 2022
@qinyer qinyer deleted the feat-cn-k8s-online branch August 3, 2022 01:10
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the K8S mirror proxy setting option
4 participants