Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the waiting time for the ks-server http service to start #490

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

zhuzhenfan
Copy link
Contributor

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

The http service of kc-server is too slow to start and the login api cannot be called.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @qinyer

@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #490 (ce468f5) into master (c71c3af) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   13.02%   12.99%   -0.03%     
==========================================
  Files         121      121              
  Lines       19020    19060      +40     
==========================================
  Hits         2477     2477              
- Misses      16263    16303      +40     
  Partials      280      280              
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 6.03% <0.00%> (-0.30%) ⬇️

Signed-off-by: zhuzhenfan <981189503@qq.com>
@kubeclipper-bot kubeclipper-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2022
@x893675
Copy link
Collaborator

x893675 commented Dec 21, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 136e58d7c1aee8c2b52aba9fd396dff3d6db3856

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@x893675
Copy link
Collaborator

x893675 commented Dec 21, 2022

/cherrypick release-1.3

@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #491

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeclipper-bot pushed a commit that referenced this pull request Dec 21, 2022
…) (#492)

Signed-off-by: zhuzhenfan <981189503@qq.com>

Signed-off-by: zhuzhenfan <981189503@qq.com>

Signed-off-by: zhuzhenfan <981189503@qq.com>
@zhuzhenfan zhuzhenfan deleted the wait branch January 12, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants