Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add registry apitest and run task #527

Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat: add registry apitest and run task #527

merged 1 commit into from
Jan 17, 2023

Conversation

sacredartr
Copy link
Contributor

Signed-off-by: sacredartr zhou.hao@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@sacredartr: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #527 (3ecf9fe) into release-1.3 (a48dbc3) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3     #527      +/-   ##
===============================================
- Coverage        12.20%   12.17%   -0.04%     
===============================================
  Files              110      110              
  Lines            16911    16956      +45     
===============================================
  Hits              2064     2064              
- Misses           14600    14645      +45     
  Partials           247      247              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.30% <0.00%> (-0.01%) ⬇️
pkg/apis/core/v1/registry.go 0.00% <0.00%> (ø)
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)
pkg/scheme/core/v1/cni/calico.go 9.92% <0.00%> (-0.15%) ⬇️
pkg/scheme/core/v1/cri/containerd.go 12.31% <0.00%> (-0.68%) ⬇️
pkg/scheme/core/v1/cri/cri.go 34.61% <ø> (ø)
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)

@kubeclipper-bot kubeclipper-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2023
Signed-off-by: sacredartr <zhou.hao@99cloud.net>
@x893675
Copy link
Collaborator

x893675 commented Jan 17, 2023

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sacredartr, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3246c085d3b28d0641974e308137cdbb03a5504b

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@kubeclipper-bot kubeclipper-bot merged commit 07784ee into kubeclipper:release-1.3 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants