Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node-ip as node-name #533

Merged
merged 1 commit into from
Jan 30, 2023
Merged

feat: add node-ip as node-name #533

merged 1 commit into from
Jan 30, 2023

Conversation

zhuzhenfan
Copy link
Contributor

Signed-off-by: zhuzhenfan 981189503@qq.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

node-ip as node-name

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @qinyer

@kubeclipper-bot kubeclipper-bot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
Signed-off-by: zhuzhenfan <981189503@qq.com>
@qinyer
Copy link
Contributor

qinyer commented Jan 19, 2023

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: baaa7265f5bc621e661cfea1ff5f606687ab5890

@x893675
Copy link
Collaborator

x893675 commented Jan 19, 2023

/hold

@x893675
Copy link
Collaborator

x893675 commented Jan 30, 2023

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@x893675
Copy link
Collaborator

x893675 commented Jan 30, 2023

/unhold

@kubeclipper-bot kubeclipper-bot merged commit f9462f7 into kubeclipper:release-1.3 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants