Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api testcases for region and node #540

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

Mengchenchen
Copy link
Collaborator

Signed-off-by: Mengchenchenmeng.chenchen@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


Signed-off-by: Mengchenchen<meng.chenchen@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@Mengchenchen: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@Mengchenchen
Copy link
Collaborator Author

/cc @sacredartr

@codecov-commenter
Copy link

Codecov Report

Merging #540 (4af9763) into release-1.3 (cc294f2) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #540   +/-   ##
============================================
  Coverage        12.18%   12.18%           
============================================
  Files              110      110           
  Lines            16975    16975           
============================================
  Hits              2068     2068           
  Misses           14660    14660           
  Partials           247      247           

@sacredartr
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a490d8b449ab40ebfc59da74d11c8603e47f1453

@x893675
Copy link
Collaborator

x893675 commented Feb 10, 2023

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mengchenchen, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@kubeclipper-bot kubeclipper-bot merged commit 1671dde into kubeclipper:release-1.3 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants