Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl create cluster --calico.ipv4-auto-detection flag checkfmt … #549

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

Xvv-v
Copy link
Contributor

@Xvv-v Xvv-v commented Feb 15, 2023

…error

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


…error

Signed-off-by: xu.jingwen <xu.jingwen@99cloud.net>
@kubeclipper-bot
Copy link
Collaborator

@Xvv-v: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2023
@Xvv-v
Copy link
Contributor Author

Xvv-v commented Feb 15, 2023

/cc @x893675

Signed-off-by: xu.jingwen <xu.jingwen@99cloud.net>
@codecov-commenter
Copy link

Codecov Report

Merging #549 (271a49e) into release-1.3 (d6f823f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3     #549      +/-   ##
===============================================
- Coverage        12.18%   12.17%   -0.01%     
===============================================
  Files              110      110              
  Lines            16975    16980       +5     
===============================================
  Hits              2068     2068              
- Misses           14660    14665       +5     
  Partials           247      247              
Impacted Files Coverage Δ
pkg/utils/autodetection/method.go 33.33% <0.00%> (-3.21%) ⬇️

@x893675
Copy link
Collaborator

x893675 commented Feb 15, 2023

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e15ed7c1a0360dfc0af40be6b7ca6e1f8710a226

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, Xvv-v

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@x893675
Copy link
Collaborator

x893675 commented Feb 15, 2023

/cherrypick master

@kubeclipper-bot kubeclipper-bot merged commit d014da8 into kubeclipper:release-1.3 Feb 15, 2023
@kubeclipper-bot
Copy link
Collaborator

@x893675: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #550

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants