Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix occasional 401 error #552

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Mar 10, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

在 metadata 中使用 generatename, 会偶现重复创建的情况。

当 etcd 中存在两个同样 token 的对象,之前的代码逻辑会报错

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Fix occasional 401 error

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2023
@x893675
Copy link
Collaborator Author

x893675 commented Mar 10, 2023

/cc @lixd

@codecov-commenter
Copy link

Codecov Report

Merging #552 (76e7af0) into release-1.3 (d014da8) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3     #552      +/-   ##
===============================================
- Coverage        12.17%   12.16%   -0.02%     
===============================================
  Files              110      111       +1     
  Lines            16980    16993      +13     
===============================================
- Hits              2068     2067       -1     
- Misses           14665    14679      +14     
  Partials           247      247              
Impacted Files Coverage Δ
pkg/utils/random/string.go 0.00% <0.00%> (ø)
pkg/authentication/auth/token.go 61.29% <100.00%> (-0.31%) ⬇️

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6c7190e47cd7963387f0d581d2149a11f7bc85f9

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit 5553ed7 into kubeclipper:release-1.3 Mar 10, 2023
@x893675
Copy link
Collaborator Author

x893675 commented Mar 10, 2023

/cherrypick master

@kubeclipper-bot
Copy link
Collaborator

@x893675: new pull request created: #553

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants