Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external etcd cluster nano-management failure #557

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Fix external etcd cluster nano-management failure #557

merged 1 commit into from
Mar 13, 2023

Conversation

zhuzhenfan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

external etcd cluster nano-management failure

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @lixd

Signed-off-by: zhuzhenfan <981189503@qq.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #557 (f943bc0) into release-1.3 (42ec95c) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #557   +/-   ##
============================================
  Coverage        12.16%   12.16%           
============================================
  Files              111      111           
  Lines            16993    16993           
============================================
  Hits              2067     2067           
  Misses           14679    14679           
  Partials           247      247           

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 86e434b899629770fa367ed25cfb2d74574f04ca

@x893675
Copy link
Collaborator

x893675 commented Mar 13, 2023

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@kubeclipper-bot kubeclipper-bot merged commit d83c7dd into kubeclipper:release-1.3 Mar 13, 2023
@zhuzhenfan
Copy link
Contributor Author

/cherry-pick master

@kubeclipper-bot
Copy link
Collaborator

@zhuzhenfan: new pull request created: #565

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhuzhenfan
Copy link
Contributor Author

/cherrypick master

@kubeclipper-bot
Copy link
Collaborator

@zhuzhenfan: new pull request could not be created: failed to create pull request against kubeclipper/kubeclipper#master from head kubeclipper-bot:cherry-pick-557-to-master: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for kubeclipper-bot:cherry-pick-557-to-master."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants