Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kcctl registry and resource subcommand #57

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

qinyer
Copy link
Contributor

@qinyer qinyer commented Jul 29, 2022

Signed-off-by: qinyer qy913726062@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #50

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: qinyer <qy913726062@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2022
@qinyer
Copy link
Contributor Author

qinyer commented Jul 29, 2022

/assign @x893675

@codecov-commenter
Copy link

Codecov Report

Merging #57 (822a2da) into master (5f688bc) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   11.39%   11.36%   -0.03%     
==========================================
  Files          92       92              
  Lines       14345    14380      +35     
==========================================
  Hits         1634     1634              
- Misses      12494    12529      +35     
  Partials      217      217              
Impacted Files Coverage Δ
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)
pkg/cli/resource/resource.go 0.76% <0.00%> (ø)
pkg/apis/core/v1/handler.go 0.34% <0.00%> (-0.01%) ⬇️

@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6f33c8575bfc90610d7279bb2da617656d42fefb

@x893675
Copy link
Collaborator

x893675 commented Aug 1, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinyer, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@kubeclipper-bot kubeclipper-bot merged commit 2e576a9 into kubeclipper:master Aug 1, 2022
@qinyer qinyer deleted the fix-kcctl branch August 1, 2022 02:54
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 1, 2022
Signed-off-by: qinyer <qy913726062@gmail.com>
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix kcctl registry and resource subcommand
5 participants