Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kcctl registry remove image failed #574

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix: kcctl registry remove image failed #574

merged 1 commit into from
Mar 31, 2023

Conversation

zhuzhenfan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

kcctl registry remove image failed

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@lixd @x893675

Signed-off-by: zhuzhenfan <981189503@qq.com>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #574 (5cdff1d) into release-1.3 (c5ea688) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3     #574      +/-   ##
===============================================
- Coverage        12.04%   12.03%   -0.02%     
===============================================
  Files              111      111              
  Lines            17156    17176      +20     
===============================================
  Hits              2067     2067              
- Misses           14841    14861      +20     
  Partials           248      248              
Impacted Files Coverage Δ
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 73f6bf18d953b8bc1bd014f1554c53bb515ae3e8

@lixd
Copy link
Contributor

lixd commented Mar 31, 2023

/cc @x893675

@x893675
Copy link
Collaborator

x893675 commented Mar 31, 2023

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@kubeclipper-bot kubeclipper-bot merged commit b52ec1f into kubeclipper:release-1.3 Mar 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants