Fix containerd template render #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: x893675 <x893675@icloud.com>
kubeclipper-bot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 11.33% 11.33%
=======================================
Files 95 95
Lines 14710 14710
=======================================
Hits 1667 1667
Misses 12822 12822
Partials 221 221 |
|
LGTM label has been added. Git tree hash: c5aba68097969a48969d004cf1d0260ff4f28a83
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: x893675 x893675@icloud.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
containerd sanbox image mirror should same with localRegistry rather than insecureRegistry
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
/cc @zhuzhenfan @qinyer