Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcctl adds the service/pod subnet parameter #584

Merged
merged 1 commit into from
Jun 16, 2023
Merged

kcctl adds the service/pod subnet parameter #584

merged 1 commit into from
Jun 16, 2023

Conversation

zhuzhenfan
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

kcctl adds the service/pod subnet parameter

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

@x893675 @lixd 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@x893675 @lixd

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #584 (e64945e) into release-1.3 (5b22d1c) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #584   +/-   ##
============================================
  Coverage        12.03%   12.03%           
============================================
  Files              111      111           
  Lines            17176    17176           
============================================
  Hits              2067     2067           
  Misses           14861    14861           
  Partials           248      248           

@x893675
Copy link
Collaborator

x893675 commented Jun 16, 2023

/assign

@x893675
Copy link
Collaborator

x893675 commented Jun 16, 2023

/kind feature

@kubeclipper-bot kubeclipper-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 16, 2023
@zhuzhenfan
Copy link
Contributor Author

/recheck

Signed-off-by: zhuzhenfan <981189503@qq.com>
@kubeclipper-bot kubeclipper-bot added dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2023
@x893675
Copy link
Collaborator

x893675 commented Jun 16, 2023

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2023
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a4e0f1bf4efd178813c28aa06e429e4a0b6aad8a

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x893675, zhuzhenfan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@kubeclipper-bot kubeclipper-bot merged commit 56c7358 into kubeclipper:release-1.3 Jun 16, 2023
5 checks passed
@wu-wenxiang
Copy link
Contributor

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants