fix: check the ubuntu-22.04 synchronization time service #592
Conversation
|
@qinyer: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeclipper-bot
added
kind/bug
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## release-1.3 #592 +/- ##
============================================
Coverage 12.05% 12.05%
============================================
Files 111 111
Lines 17146 17146
============================================
Hits 2067 2067
Misses 14831 14831
Partials 248 248
|
|
LGTM label has been added. Git tree hash: 07446725bab86f588ac191be8427486562db4a28
|
pkg/cli/deploy/deploy.go
Outdated
| @@ -295,7 +295,7 @@ var ( | |||
| precheckKcServerFunc = generateCommonPreCheckFunc("kc-server") | |||
| precheckKcAgentFunc = generateCommonPreCheckFunc("kc-agent") | |||
| precheckNtpFunc precheckFunc = func(sshConfig *sshutils.SSH, host string) error { | |||
| ret, err := sshutils.SSHCmdWithSudo(sshConfig, host, "systemctl --all --type service --state running | grep -e chrony -e ntpd|wc -l") | |||
| ret, err := sshutils.SSHCmdWithSudo(sshConfig, host, "systemctl --all --type service --state running | grep -e chrony -e ntpd -e ntp|wc -l") | |||
There was a problem hiding this comment.
直接 -e ntp 可以涵盖 ntpd 和 ntp 吧
Signed-off-by: qinyer <qy913726062@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, qinyer, wu-wenxiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeclipper-bot
added
the
approved
|
/lgtm |
|
LGTM label has been added. Git tree hash: 04687d4ab4fd867a9b0012763dd95ac53f87cd74
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ubuntu-22.04 synchronization time service name is
ntp.service, so detecting it during deploymentWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: