Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cronbackup controller #60

Merged
merged 4 commits into from
Aug 2, 2022
Merged

update cronbackup controller #60

merged 4 commits into from
Aug 2, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Aug 1, 2022

Signed-off-by: liuchuwei liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

BackupPoint and cronBackup of back-end service logs reporting errors

Which issue(s) this PR fixes:

Fixes #59

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: liuchuwei <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2022
Signed-off-by: liuchuwei <liu.chuwei@99cloud.net>
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #60 (b805ec8) into master (84faa6f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   11.33%   11.33%   -0.01%     
==========================================
  Files          95       95              
  Lines       14710    14721      +11     
==========================================
+ Hits         1667     1668       +1     
- Misses      12822    12832      +10     
  Partials      221      221              
Impacted Files Coverage Δ
pkg/scheme/core/v1/cri/containerd.go 2.42% <0.00%> (-0.08%) ⬇️
pkg/scheme/core/v1/k8s/kubeadm.go 3.51% <0.00%> (-0.03%) ⬇️
pkg/cli/join/join.go 0.00% <0.00%> (ø)
pkg/cli/registry/registry.go 0.00% <0.00%> (ø)
pkg/cli/resource/resource.go 0.76% <0.00%> (ø)
pkg/scheme/core/v1/k8s/kubeadm_step.go 0.00% <0.00%> (ø)
pkg/cli/deploy/deploy.go 16.15% <0.00%> (+0.12%) ⬆️

@x893675
Copy link
Collaborator

x893675 commented Aug 1, 2022

@zhuzhenfan

liuchuwei added 2 commits August 2, 2022 09:58
Signed-off-by: liuchuwei <liu.chuwei@99cloud.net>
Signed-off-by: liuchuwei <liu.chuwei@99cloud.net>
@zhuzhenfan
Copy link
Contributor

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 1aa8255d88b18b3ad766e887e514fbadbb586c64

@x893675 x893675 changed the title update cronbackup controller.go 2022/08/01 update cronbackup controller Aug 2, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 2, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@kubeclipper-bot kubeclipper-bot merged commit 5160674 into kubeclipper:master Aug 2, 2022
@zhuzhenfan
Copy link
Contributor

/lgtm

@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cronBackup of back-end service logs reporting errors
5 participants