Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout #685

Merged
merged 1 commit into from Mar 5, 2024
Merged

Fix timeout #685

merged 1 commit into from Mar 5, 2024

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Mar 5, 2024

What type of PR is this?

/kind flake

What this PR does / why we need it:

kcctl deploy command add kcServerHealthCheckTimeout flag to speicfy health check timeout,e.g. --kcServerHealthCheckTimeout 60s

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added release-note-none kind/flake Categorizes issue or PR as related to a flaky test. dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 14.14%. Comparing base (e5f7f95) to head (986a88d).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
+ Coverage   14.13%   14.14%   +0.01%     
==========================================
  Files         142      142              
  Lines       20077    20093      +16     
==========================================
+ Hits         2838     2843       +5     
- Misses      16948    16958      +10     
- Partials      291      292       +1     
Files Coverage Δ
pkg/cli/deploy/deploy.go 5.72% <0.00%> (ø)
pkg/clusteroperation/node.go 57.55% <31.25%> (-2.70%) ⬇️

@x893675
Copy link
Collaborator

x893675 commented Mar 5, 2024

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d1add125a84a8edc064d7b6e481c918c7f703475

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@kubeclipper-bot kubeclipper-bot merged commit 400c3ee into kubeclipper:master Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants