Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ip detect config #71

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 3, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

add kc-agent ip-detect method config.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

kcctl deploy / join add an ip-detect flag to config kc-agent's ip-detect method.
kc-agent read /etc/kubeclipper-agent/kubeclipper-agent.yaml file to get ip-detect method when need. such as install k8s, kc-agent will get the ip-detect method to find the current node's ip.

Does this PR introduced a user-facing change?

kcctl deploy / join add an ip-detect flag

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added release-note kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #71 (a1b6605) into master (07cee4f) will increase coverage by 0.39%.
The diff coverage is 46.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   11.30%   11.69%   +0.39%     
==========================================
  Files          95       98       +3     
  Lines       14792    14951     +159     
==========================================
+ Hits         1672     1749      +77     
- Misses      12898    12972      +74     
- Partials      222      230       +8     
Impacted Files Coverage Δ
pkg/cli/join/join.go 0.00% <0.00%> (ø)
pkg/scheme/core/v1/k8s/cluster.go 0.12% <0.00%> (-0.01%) ⬇️
pkg/scheme/core/v1/k8s/kubeadm.go 3.29% <0.00%> (-0.06%) ⬇️
pkg/cli/deploy/deploy.go 16.20% <20.00%> (+0.05%) ⬆️
pkg/utils/autodetection/method.go 36.53% <36.53%> (ø)
pkg/utils/autodetection/filtered.go 65.21% <65.21%> (ø)
pkg/utils/autodetection/interface.go 67.16% <67.16%> (ø)
pkg/utils/netutil/netutil_linux.go 37.50% <80.00%> (+4.16%) ⬆️

@lixd
Copy link
Contributor Author

lixd commented Aug 3, 2022

/assign @x893675

Signed-off-by: lixd <xueduan.li@gmail.com>
Signed-off-by: lixd <xueduan.li@gmail.com>
@lixd
Copy link
Contributor Author

lixd commented Aug 4, 2022

/cc @x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 4, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 945c35b49b86cd49803a699f62801d6eee38dddd

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@kubeclipper-bot kubeclipper-bot merged commit 6c68f30 into kubeclipper:master Aug 4, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants