Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid got a wrong default gateway. #74

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 4, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

avoid got a wrong default gateway.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

before
when the default gateway is not first elements will get a wrong value, And if no default gateway will get another gateway as result.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none and removed do-not-merge/release-note-label-needed labels Aug 4, 2022
@lixd
Copy link
Contributor Author

lixd commented Aug 4, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 5, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 4091ccf6a0538a5d7e973a5feb2814e91cf686b4

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2022
@kubeclipper-bot kubeclipper-bot merged commit c571669 into kubeclipper:master Aug 5, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
@lixd lixd deleted the fix_default_gateway branch October 25, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants