Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ip detect precheck #78

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

lixd
Copy link
Contributor

@lixd lixd commented Aug 8, 2022

Signed-off-by: lixd xueduan.li@gmail.com

What type of PR is this?

/kind flake

What this PR does / why we need it:

add ip detect precheck, print a hint if the node has multi nic but --ip-detect not specified.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

use cmd ip a|grep ": "|awk {'print $2'}|sed 's/://' to print ifaces.
filter logic iface, if > 1,print a hint.

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: lixd <xueduan.li@gmail.com>
@kubeclipper-bot kubeclipper-bot added kind/flake Categorizes issue or PR as related to a flaky test. release-note-none dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #78 (3b67d3e) into master (03e4969) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   11.67%   11.66%   -0.01%     
==========================================
  Files          98       98              
  Lines       15002    15005       +3     
==========================================
  Hits         1751     1751              
- Misses      13022    13025       +3     
  Partials      229      229              
Impacted Files Coverage Δ
pkg/cli/deploy/deploy.go 16.13% <0.00%> (-0.08%) ⬇️
pkg/cli/join/join.go 0.00% <0.00%> (ø)

@lixd
Copy link
Contributor Author

lixd commented Aug 8, 2022

/assign @x893675

@x893675
Copy link
Collaborator

x893675 commented Aug 8, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 615318ae688f7221f3d845ebd699a6da8e06cffd

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@kubeclipper-bot kubeclipper-bot merged commit 24c4925 into kubeclipper:master Aug 8, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
@lixd lixd deleted the fix_precheck branch August 12, 2022 10:11
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 15, 2022
Signed-off-by: lixd <xueduan.li@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants