Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create one-time cron backup should not earlier than the current … #79

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Aug 8, 2022

…time

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #73

Special notes for reviewers:

@x893675 @zhuzhenfan 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


…time

Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none dco-signoff: yes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #79 (b8578ea) into master (f981490) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   11.67%   11.66%   -0.01%     
==========================================
  Files          98       98              
  Lines       15003    15009       +6     
==========================================
  Hits         1751     1751              
- Misses      13023    13029       +6     
  Partials      229      229              
Impacted Files Coverage Δ
pkg/apis/core/v1/handler.go 0.34% <0.00%> (-0.01%) ⬇️
pkg/cli/deploy/deploy.go 16.13% <0.00%> (-0.08%) ⬇️
pkg/cli/join/join.go 0.00% <0.00%> (ø)

Liucw added 2 commits August 8, 2022 16:12
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@x893675
Copy link
Collaborator

x893675 commented Aug 8, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0e56b9d069f5f53a67b97d61676f4809a32d6126

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@kubeclipper-bot kubeclipper-bot merged commit 2b824b0 into kubeclipper:master Aug 8, 2022
@x893675 x893675 added this to the v1.1.0 milestone Aug 10, 2022
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 15, 2022
kubeclipper#79)

* fix: create one-time cron backup should not earlier than the current time

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

* update create cron backup

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

* update create cron backup sec.

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

Co-authored-by: Liucw <liu.chuwei@99cloud.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

the specified run time of one-time cron backups needs to be later than the current time
4 participants