Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cronbackup without updating next schedule time #86

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

Metrora
Copy link
Contributor

@Metrora Metrora commented Aug 10, 2022

Signed-off-by: Liucw liu.chuwei@99cloud.net

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #84

Special notes for reviewers:

@x893675 @zhuzhenfan 

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: Liucw <liu.chuwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 10, 2022

/cc @lixd @zhuzhenfan

Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d6e3817c417ae7c9b20737ba82a6090d847e5b6d

@x893675
Copy link
Collaborator

x893675 commented Aug 10, 2022

/milestone v1.1.0

@kubeclipper-bot kubeclipper-bot added this to the v1.1.0 milestone Aug 10, 2022
@x893675
Copy link
Collaborator

x893675 commented Aug 10, 2022

/approve

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, Metrora, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@kubeclipper-bot kubeclipper-bot merged commit 65bafe8 into kubeclipper:master Aug 10, 2022
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 15, 2022
…er#86)

Signed-off-by: Liucw <liu.chuwei@99cloud.net>

Co-authored-by: Liucw <liu.chuwei@99cloud.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

After modifying the time of the scheduled backup, the backup is not generated
4 participants