-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme #94
update readme #94
Conversation
Signed-off-by: x893675 <x893675@icloud.com>
/cc @lixd |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 11.65% 11.65%
=======================================
Files 98 98
Lines 15023 15023
=======================================
Hits 1751 1751
Misses 13043 13043
Partials 229 229 |
README_zh.md
Outdated
## 开发和调试 | ||
|
||
1. fork repo and clone | ||
2. run etcd locally, usually use docker / podman to run etcd container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这句需要翻译成中文吗🤔
README_zh.md
Outdated
请参考 [Community](https://github.com/kubeclipper-labs/community) 的相关文档,参与我们 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参与我们 --> 加入我们 感觉比较好
Signed-off-by: x893675 <x893675@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 2a4623699706d292747d086dfcc75bd9775c86f2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update readme Signed-off-by: x893675 <x893675@icloud.com> * update translation Signed-off-by: x893675 <x893675@icloud.com> Signed-off-by: x893675 <x893675@icloud.com>
Signed-off-by: x893675 x893675@icloud.com
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #12
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: