Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme #94

Merged
merged 2 commits into from
Aug 11, 2022
Merged

update readme #94

merged 2 commits into from
Aug 11, 2022

Conversation

x893675
Copy link
Collaborator

@x893675 x893675 commented Aug 11, 2022

Signed-off-by: x893675 x893675@icloud.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #12

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: x893675 <x893675@icloud.com>
@kubeclipper-bot kubeclipper-bot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none dco-signoff: yes approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2022
@x893675
Copy link
Collaborator Author

x893675 commented Aug 11, 2022

/cc @lixd

@codecov-commenter
Copy link

Codecov Report

Merging #94 (4b21c96) into master (65bafe8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   11.65%   11.65%           
=======================================
  Files          98       98           
  Lines       15023    15023           
=======================================
  Hits         1751     1751           
  Misses      13043    13043           
  Partials      229      229           

README_zh.md Outdated
## 开发和调试

1. fork repo and clone
2. run etcd locally, usually use docker / podman to run etcd container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句需要翻译成中文吗🤔

README_zh.md Outdated
请参考 [Community](https://github.com/kubeclipper-labs/community) 的相关文档,参与我们
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参与我们 --> 加入我们 感觉比较好

Signed-off-by: x893675 <x893675@icloud.com>
Copy link
Contributor

@lixd lixd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2a4623699706d292747d086dfcc75bd9775c86f2

@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lixd, x893675

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit 9fe84df into kubeclipper:master Aug 11, 2022
@x893675 x893675 deleted the update-readme branch August 12, 2022 09:13
Xvv-v pushed a commit to Xvv-v/kubeclipper that referenced this pull request Aug 15, 2022
* update readme

Signed-off-by: x893675 <x893675@icloud.com>

* update translation

Signed-off-by: x893675 <x893675@icloud.com>

Signed-off-by: x893675 <x893675@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update readme
4 participants