Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create HA cluster e2e test spec #98

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat: add create HA cluster e2e test spec #98

merged 1 commit into from
Aug 16, 2022

Conversation

sacredartr
Copy link
Contributor

What type of PR is this?

/kind flake

What this PR does / why we need it:

add create HA cluster e2e test spec

Which issue(s) this PR fixes:

Fixes #87

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@kubeclipper-bot kubeclipper-bot added kind/flake Categorizes issue or PR as related to a flaky test. dco-signoff: no do-not-merge/release-note-label-needed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #98 (2cbecde) into master (9fe84df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files          98       98           
  Lines       15040    15040           
=======================================
  Hits         1751     1751           
  Misses      13060    13060           
  Partials      229      229           

@sacredartr
Copy link
Contributor Author

/cc @x893675

if len(nodes.Items) < 2 {
framework.Failf("Not enough nodes to test")
}
nodeList = corev1.WorkerNodeList{
Copy link
Contributor

@Xvv-v Xvv-v Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master node can't be even number

Signed-off-by: sacredartr <zhou.hao@99cloud.net>
@sacredartr sacredartr requested a review from Xvv-v August 12, 2022 09:53
@Xvv-v
Copy link
Contributor

Xvv-v commented Aug 16, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 7ee3deb0319e01fcab62589ca4c80207f47bf545

@x893675
Copy link
Collaborator

x893675 commented Aug 16, 2022

/release-note-none

@x893675
Copy link
Collaborator

x893675 commented Aug 16, 2022

/approve

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sacredartr, x893675, Xvv-v

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit 4f26e02 into kubeclipper:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add create HA cluster e2e test spec
5 participants