Revert "Change method of checking if networking.k8s.io/v1/Ingress is … #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported" This reverts commit 3d1f53d.
gracedo
approved these changes
Feb 25, 2022
AjayTripathy
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…supported"
This reverts commit 3d1f53d.
What does this PR change?
Revert commit that changes ingress spec logic from using
.Capabilities.KubeVersionto.Capabilities.APIVersions, as this change has been causing issues with the ingress template.Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
Tested on 1.22 GKE cluster with ingress enabled, as well as with helm template/helm install --dry-run.
Have you made an update to documentation?