Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'app' label is overwritten by commonLabels for kubecost metrics … #1323

Merged

Conversation

mortenmj
Copy link
Contributor

@mortenmj mortenmj commented Mar 22, 2022

What does this PR change?

This fixes a duplicate "app" label in the kubecost-agent Deployment

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

No impact

Links to Issues or ZD tickets this PR addresses or fixes

How was this PR tested?

Diffed the result between the chart in develop and in this branch:

➜ ~ diff -u original.yaml updated.yaml
--- original.yaml 2022-03-22 16:40:01.622002841 +0100
+++ updated.yaml 2022-03-22 16:40:15.382002845 +0100
@@ -18177,11 +18177,10 @@
name: kubecost-agent
labels:

- app.kubernetes.io/name: cost-analyzer
- helm.sh/chart: cost-analyzer-1.91.0
app.kubernetes.io/instance: kubecost
app.kubernetes.io/managed-by: Helm
- app: cost-analyzer
+ app.kubernetes.io/name: cost-analyzer
+ helm.sh/chart: cost-analyzer-1.91.0
app: kubecost-agent
spec:
replicas: 1

Copy link
Member

@nealormsbee nealormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The changes follow the same procedure as was used to remove duplicate labels in #1299

Thanks for the submission!

@nealormsbee nealormsbee merged commit 844b1ab into kubecost:develop Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants