remove server block and associated values #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbolt35
approved these changes
Mar 28, 2022
| @@ -653,6 +637,15 @@ initChownData: | |||
| grafana: | |||
| # namespace_datasources: kubecost # override the default namespace here | |||
| # namespace_dashboards: kubecost # override the default namespace here | |||
| datasources: | |||
There was a problem hiding this comment.
Oh nevermind, didn't realize you doubled up PRs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Remove cost-analyzer-server which has been deprecated for several releases!
Also repairs the default grafana install.
Does this PR rely on any other PRs?
A number of PRs deprecating cost-analyzer-server.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Fewer containers to run, save memory
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
atripathy@Ajays-MacBook-Pro builds % kubectl get pods -n kubecost
NAME READY STATUS RESTARTS AGE
kubecost-cost-analyzer-578f956bcd-pwcng 2/2 Running 0 18m
Plus integration testing to make sure all endpoints referencing this have been removed.
For grafana:
After restarting the grafana pod:
Have you made an update to documentation?
There are many references to cost-analyzer-server that should be removed scattered throughout the docs. Let's make a note and remove these as we find them.