Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize Thanos deployment strategies #1331

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

keithhand
Copy link
Contributor

What does this PR change?

It gives users the ability to customize the Thanos deployment strategies via custom values.yaml options.

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Added option to customize Thanos deployment strategies.

Links to Issues or ZD tickets this PR addresses or fixes

How was this PR tested?

First, I used a GKE cluster with Thanos installed where I was receiving the "Multi-Attach error for volume" error. I confirmed the upgrade could not process and checked the status of the deployment strategies with the following command:

❯ kubectl get deploy -l="app.kubernetes.io/name=thanos" -ojsonpath='{.items[*].spec.strategy.type}'
RollingUpdate RollingUpdate RollingUpdate RollingUpdate RollingUpdate

I then upgraded the cluster with the values:

thanos:
  store:
    deploymentStrategy: 
      type: Recreate
  query:
    deploymentStrategy: 
      type: Recreate
  query-frontend:
    deploymentStrategy: 
      type: Recreate
  compact:
    deploymentStrategy: 
      type: Recreate
  bucket:
    deploymentStrategy: 
      type: Recreate

I tested the same command before to confirm the deployment strategy, and I confirmed that the upgrade was now working.

❯ kubectl get deploy -l="app.kubernetes.io/name=thanos" -ojsonpath='{.items[*].spec.strategy.type}'
Recreate Recreate Recreate Recreate Recreate

Have you made an update to documentation?

Added value description in charts/thanos/values.yaml

@keithhand keithhand added enhancement New feature or request next release labels Mar 29, 2022
@keithhand keithhand merged commit 012fed6 into develop Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to customize Thanos deployment strategy types
3 participants