Add option to customize Thanos deployment strategies #1331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
It gives users the ability to customize the Thanos deployment strategies via custom
values.yaml
options.How does this PR impact users? (This is the kind of thing that goes in release notes!)
Added option to customize Thanos deployment strategies.
Links to Issues or ZD tickets this PR addresses or fixes
How was this PR tested?
First, I used a GKE cluster with Thanos installed where I was receiving the "Multi-Attach error for volume" error. I confirmed the upgrade could not process and checked the status of the deployment strategies with the following command:
❯ kubectl get deploy -l="app.kubernetes.io/name=thanos" -ojsonpath='{.items[*].spec.strategy.type}' RollingUpdate RollingUpdate RollingUpdate RollingUpdate RollingUpdate
I then upgraded the cluster with the values:
I tested the same command before to confirm the deployment strategy, and I confirmed that the upgrade was now working.
❯ kubectl get deploy -l="app.kubernetes.io/name=thanos" -ojsonpath='{.items[*].spec.strategy.type}' Recreate Recreate Recreate Recreate Recreate
Have you made an update to documentation?
Added value description in
charts/thanos/values.yaml