Re-Templated kubecost.yaml to support 1.25+ clusters. #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmdresser
approved these changes
Jan 31, 2023
|
Great question - lots of ideas here. probably need to have a more thorough review and have a good permanent url for the file so we can add it to the automation scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Retemplates our kubecost.yaml to support V1.25+ versions of K8s
Does this PR rely on any other PRs?
No
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Allows them to install via the generated manifests instead of helm on clusters V1.25 and above.
Links to Issues or ZD tickets this PR addresses or fixes
Issue
How was this PR tested?
Tested with raw file committed:
Command Executed
helm template kubecost ./cost-analyzer --namespace kubecost > kubecost.yamlHave you made an update to documentation?