Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation for the Kubecost Admission Controller #2629

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

thomasvn
Copy link
Member

@thomasvn thomasvn commented Oct 6, 2023

What does this PR change?

  • Adds documentation for the Kubecost Admission Controller

Does this PR rely on any other PRs?

  • No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • N/a

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

  • None. Kubecost Admission Controller is not enabled by default.

How was this PR tested?

Validated that none of the Kubecost Admission Controller secrets, environment variables, templates were rendered in a default configuration.

helm template cost-analyzer

Have you made an update to documentation? If so, please provide the corresponding PR.

Copy link
Collaborator

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas, great to see these comments. Thank you, it's super helpful. Can we perhaps also include a link to the docs (if extant?) which explain what this does and why a user wants/needs it?

@chipzoller
Copy link
Collaborator

You're linking to a PR in a private repository while this PR is in a public one just FYI.

@thomasvn
Copy link
Member Author

@chipzoller No documentation currently exists for this feature, so for now I've opened up kubecost/docs#749. Does the rest of the PR look good for approval?

Copy link
Collaborator

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks ok.

@chipzoller chipzoller merged commit cc56f30 into develop Oct 10, 2023
8 checks passed
@chipzoller chipzoller deleted the thomasn/document-admission-controller branch October 10, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants