Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create checksum for configmaps and secrets to enforce restart w… #3407

Closed

Conversation

jkleinlercher
Copy link

…hen really needed in a gitops friendly way

What does this PR change?

with this PR deployments where "helm-rollout-restarter" annotation or label is used, I introduced a checksum of rendered configmaps and secrets. the configmaps and secrets which are honored are listed in the _helpers.tpl function configsChecksum. So this list needs to be maintained.

Does this PR rely on any other PRs?

How does this PR impact users? (This is the kind of thing that goes in release notes!)

with this PR pods get restarted also when cicd is set to true

Links to Issues or tickets this PR addresses or fixes

fixes #3403

What risks are associated with merging this PR? What is required to fully test this PR?

How was this PR tested?

helm template . |grep checksum
        checksum/configs: df0658db2eb919288b37b12dc7dde460d4d19890c81e085c945f39c468d33256
        checksum/configs: df0658db2eb919288b37b12dc7dde460d4d19890c81e085c945f39c468d33256

helm template . --set kubecostToken=blub | grep checksum
        checksum/configs: b472370c2d05a1e7b3dabf7b269fddb5722c91b90d63fa1a9d253ac89793e52e
        checksum/configs: b472370c2d05a1e7b3dabf7b269fddb5722c91b90d63fa1a9d253ac89793e52e

Have you made an update to documentation? If so, please provide the corresponding PR.

no

…hen really needed in a gitops friendly way

Signed-off-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>
@jessegoodier
Copy link
Collaborator

This is awesome!
I won't have time to test before our 2.3.0 GA, but I think we can get this in .1 or .2
Thank you for doing this!

@jessegoodier jessegoodier self-assigned this May 17, 2024
@jkleinlercher jkleinlercher closed this by deleting the head repository Jun 9, 2024
@jessegoodier
Copy link
Collaborator

@jkleinlercher did you close this due to an issue?
I had been waiting for GA of 2.3, which I hope will be this week.

Would love to this this in!

@jkleinlercher
Copy link
Author

Oh no I unintentionally deleted my fork, that’s why this issue got closed. I need to figure out how I can recreate my fork. Sorry!!

@jkleinlercher
Copy link
Author

@jessegoodier I created a new PR #3459 for this. sorry for any inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] replace helm-rollout-restarter method with helm best practice to restart pods on configmap changes
2 participants