Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Alertmanager by default #779

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Disable Alertmanager by default #779

merged 2 commits into from
Mar 8, 2021

Conversation

dwbrown2
Copy link
Contributor

The majority of users are not leveraging Alertmanager and are instead using our in-product alerts. This proposal is to disable it by default.

The majority of users are not leveraging Alertmanager and are instead using our in-product alerts. This proposal is to disable it by default.
@dwbrown2
Copy link
Contributor Author

@AjayTripathy can you help with testing? Also, are there any unintended consequences from this change?

We should very clearly highlight in the associated release.

@AjayTripathy
Copy link
Contributor

I'm happy to help with testing the long tail of any unintended consequences, but can you please share what the expected behavior is and what testing has been done so far if any? Have at least these 2 been done?

  1. alertmanager is no longer installed by default
  2. alertmanager is installed when this is set to true (no regression)

@dwbrown2
Copy link
Contributor Author

dwbrown2 commented Mar 8, 2021

I have tested by confirming the following:

  1. the current values do not cause any noticeable regressions in the core kubecost application and do disable AlertManager as expected
  2. both commenting the line out again and setting this value to true both cause alertmanger to be deployed

@AjayTripathy please feel free to test any other cases you can think of but this seemed sufficient to me

@AjayTripathy
Copy link
Contributor

Yep agreed. we'll get this merged and rolled into our integration tests.

@AjayTripathy AjayTripathy merged commit de88df6 into develop Mar 8, 2021
@chipzoller chipzoller deleted the dwbrown2-patch-18 branch October 4, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants