New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm config parameter for shared overhead costs #987

Merged

kaelanspatel merged 1 commit into develop from kaelan-helmsharedoverhead

Aug 25, 2021

Contributor

kaelanspatel commented Jul 20, 2021 •

edited

Ref #972
Requires opencost/opencost#870

Add sharedOverhead to values.yaml which allows users to set the value for "Shared Overhead" from the settings page.


          Create sharedOverhead param

c848e36

kaelanspatel mentioned this pull request

Add helm config parameter for shared overhead costs opencost/opencost#870

Merged

kaelanspatel requested a review from mbolt35

July 20, 2021 00:24

Contributor

mbolt35 commented Jul 20, 2021

Looks good to me once opencost/opencost#870 is approved.

mbolt35 approved these changes

View reviewed changes

nikovacevic approved these changes

View reviewed changes

kaelanspatel merged commit 717d8b5 into develop

kaelanspatel deleted the kaelan-helmsharedoverhead branch

August 25, 2021 19:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment