Refactor some commands to reduce code duplication #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2022
nikovacevic
approved these changes
Jun 15, 2022
Uses a command "generator" for common aggregation situations (not label) and updates table writing to more generically accept arbitrary aggregation levels. This will make future improvements to kubectl-cost easier by reducing the amount of code that needs to be updated.
michaelmdresser
force-pushed
the
mmd/refactor-command-generation-allocation
branch
from
0217c06
to
fb9e148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds a command "generator" for common aggregation situations (not label)
and updates table writing to more generically accept arbitrary aggregation
levels. This will make future improvements to kubectl-cost easier by
reducing the amount of code that needs to be updated.
How was this PR tested?
Against a GKE cluster with Kubecost installed.