Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for predict launch in v1.100 #140

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

michaelmdresser
Copy link
Contributor

What does this PR change?

LIVE PREVIEW OF README CHANGES: https://github.com/kubecost/kubectl-cost/blob/mmd/predict-launch-readme/README.md

Update of README to highlight kubectl cost predict launch.

@dwbrown2 can you comment on the copy/example/placement? I used a highly truncated example output to keep it snappy at the top -- there are more detailed examples later in the README already. I'm not very adept at design, so I'm welcoming all ideas.

@michaelmdresser
Copy link
Contributor Author

@bstuder99 a review of the copy would be most welcome, if you have the time

README.md Outdated Show resolved Hide resolved
> for examples. Let us know how it goes, and open an issue if you encounter any
> problems!

‼️ New! Starting with Kubecost v1.100, `kubectl cost` can estimate the cost of undeployed changes! Try it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if exclamation marks in tech docs go well together. I'd like to hype this but I'm thinking we scale back the enthusiasm. Maybe: "New: As of Kubecost v1.100, ...of undeployed changes."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to have some color here, rather than just bolding. There's a lot to be said for a GitHub README that pops on first view, which is why we already have some GIFs. Do you think there's a way we could incorporate some eye-catching color (or some other mechanism) to draw attention to the new feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we want to use an image file (.png or .gif), which would be the most immediate implementation, we may have to look at third party plugins. I haven't implemented one of these in the past, but this should have what you're looking for:
https://docs.gitlab.com/ee/user/markdown.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean to say is: emojis are an easy way to add color that are supported by default in GitHub markdown, which is why I went for some sort of emoji. Given that a README is half marketing landing page, half documentation, is an emoji inappropriate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I wasn't aware that was supposed to be an emoji. In general I would say we should avoid them in tech docs, but there are existing exceptions like on our 3-step Kubecost install page which I've received pushback on weirdly. For now, I'm just going to table this and try to find a consistent system of using these "banners" across our docs, just as in warnings.

Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser michaelmdresser merged commit 5383b73 into main Feb 10, 2023
@michaelmdresser michaelmdresser deleted the mmd/predict-launch-readme branch February 10, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants