Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New vertical format for predict #144

Merged
merged 18 commits into from
Mar 3, 2023
Merged

New vertical format for predict #144

merged 18 commits into from
Mar 3, 2023

Conversation

michaelmdresser
Copy link
Contributor

@michaelmdresser michaelmdresser commented Feb 28, 2023 •
edited
Loading

What does this PR change?

Note verticality is a little excessive when object names wrap. See jedib0t/go-pretty#261.

Does this PR rely on any other PRs?

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Overhauled kubectl cost predict formatting to use less horizontal space while adding more data: resource amounts, resource prices, and % cost change.

How was this PR tested?

$ go run cmd/kubectl-cost/kubectl-cost.go predict -r michaelkc -f ./test/multi.yaml

 OBJECT                        Δ QTY  RESOURCE UNIT   COST PER UNIT     Δ COST/MO  % CHANGE 
────────────────────────────────────────────────────────────────────────────────────────────
 michaelkc deployment             +9  CPU cores           23.27 USD   +209.47 USD           
 nginx-deployment                                                                           
                                  +6  RAM GiB              3.12 USD    +18.72 USD           
                                                                                            
────────────────────────────────────────────────────────────────────────────────────────────
 kubecost deployment             +15  CPU millicores      0.023 USD     +0.35 USD           
 kubecost-cost-analyzer                                                                     
                                  +9  RAM MiB            0.0030 USD     +0.03 USD           
                                                                                            
────────────────────────────────────────────────────────────────────────────────────────────
 michaelkc deployment            -92  CPU millicores      0.023 USD     -2.14 USD   -92.00% 
 michaelkc-cost-analyzer                                                                    
                             -172.65  RAM MiB            0.0030 USD     -0.53 USD   -43.38% 
                                                                                            
────────────────────────────────────────────────────────────────────────────────────────────
 michaelkc deployment            +10  CPU cores           23.27 USD   +232.74 USD           
 nginx-deployment-2                                                                         
                                 +35  RAM GiB              3.12 USD   +109.17 USD           
                                                                                            
                                  +5  GPUs               693.50 USD  +3467.50 USD           
                                                                                            
────────────────────────────────────────────────────────────────────────────────────────────
 michaelkc pod nginx-pod        +350  CPU millicores      0.023 USD     +8.15 USD           
                                +200  RAM MiB            0.0030 USD     +0.61 USD           
                            ────────────────────────────────────────────────────────────────
                                +350  CPU millicores      0.023 USD     +8.15 USD           
                                +200  RAM MiB            0.0030 USD     +0.61 USD           
                                  +3  GPUs               693.50 USD  +2080.50 USD           
────────────────────────────────────────────────────────────────────────────────────────────
 TOTAL MONTHLY COST CHANGE                                           +6133.32 USD

Have you made an update to documentation?

See README updates

@michaelmdresser michaelmdresser changed the base branch from main to mmd/use-new-spec-predict February 28, 2023 00:21
@michaelmdresser michaelmdresser changed the title WIP: New vertical format for predict New vertical format for predict Mar 1, 2023
Base automatically changed from mmd/use-new-spec-predict to main March 1, 2023 21:53
@michaelmdresser
Update speccost query with new data
96b8538 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
first vertical attempt, one table per
de29ae5 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Better style for many tables
892eacf 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Add total cost to the end of output
d833910 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Add GPU row if any GPU data exists
0f9a5b2 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Remove defunct flags
9a59e1f 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
More condensed, variable unit factor, fmting float
e1f09da 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Remove FIXME because update made it into v1.101
0750f1e 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Remove omitempty; API change made it into v1.101
80d5779 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Align all columns by putting back in one table
4ad9a5e 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Format predict columns with transformers
47b0db2 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Add pct change column and associated test workload
a4d686d 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Rename workload column to object for generality
eb4d46a 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Column naming clarity
697f0bd 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Preserve horizontal space at the expense of verti
e70f3e8 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Don't show CPU and RAM if no data
38405d8 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
Update README with new vertical format
5680a7a 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser
specify namespace in example
d236ba7 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser michaelmdresser force-pushed the mmd/predict-new-vertical-format branch from 0a86dc3 to d236ba7 Compare March 1, 2023 21:59
@michaelmdresser michaelmdresser marked this pull request as ready for review March 1, 2023 21:59
CampfireRemnants
CampfireRemnants approved these changes Mar 2, 2023
View reviewed changes
Copy link

@CampfireRemnants CampfireRemnants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!

@michaelmdresser michaelmdresser merged commit 1372c1b into main Mar 3, 2023
@michaelmdresser michaelmdresser deleted the mmd/predict-new-vertical-format branch March 3, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CampfireRemnants CampfireRemnants CampfireRemnants approved these changes

@nikovacevic nikovacevic Awaiting requested review from nikovacevic

@avrodrigues5 avrodrigues5 Awaiting requested review from avrodrigues5

@saweber saweber Awaiting requested review from saweber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelmdresser @CampfireRemnants