Show overall efficiency #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwbrown2
approved these changes
May 6, 2021
dwbrown2
reviewed
May 6, 2021
pkg/cmd/output.go
Outdated
| @@ -108,6 +108,14 @@ func makeAllocationTable(allocationType string, allocations map[string]kubecost. | |||
| AlignFooter: text.AlignRight, | |||
| }) | |||
|
|
|||
| if opts.showEfficiency { | |||
| columnConfigs = append(columnConfigs, table.ColumnConfig{ | |||
| Name: "Total Efficiency", | |||
There was a problem hiding this comment.
Should this be "Cost" or "Spend" efficiency? I would want to highlight that this is not a straight utilization calculation.
There was a problem hiding this comment.
I think so. Changed to "Cost Efficiency."
dwbrown2
approved these changes
May 6, 2021
pkg/cmd/output.go
Outdated
| @@ -377,6 +397,14 @@ func makeAggregationRateTable(aggs map[string]query.Aggregation, rowTitles []str | |||
| AlignFooter: text.AlignRight, | |||
| }) | |||
|
|
|||
| if opts.showEfficiency { | |||
| columnConfigs = append(columnConfigs, table.ColumnConfig{ | |||
| Name: "Monthly Efficiency", | |||
There was a problem hiding this comment.
Changed to "Cost Efficiency."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #79
Tested locally against a GKE cluster.