Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/disconnect cause failure #32

Merged
merged 12 commits into from
Aug 31, 2021
Merged

Bugfix/disconnect cause failure #32

merged 12 commits into from
Aug 31, 2021

Conversation

weilaaa
Copy link
Member

@weilaaa weilaaa commented Aug 24, 2021

Ⅰ. Describe what this PR does

  1. reconnect retry if member cluster is unreachable when startup kubecube
  2. fast fail return if cluster is unhealthy
  3. cluster status refresh when member cluster is disconnected

Ⅱ. Does this pull request fix one issue?
#18

@weilaaa weilaaa requested a review from fusidamj August 24, 2021 09:46
fusidamj
fusidamj requested changes Aug 25, 2021
View reviewed changes
pkg/ctrlmgr/controllers/cluster/cluster_controller.go Show resolved Hide resolved
pkg/scout/scout.go Show resolved Hide resolved
pkg/scout/scout.go Show resolved Hide resolved
pkg/ctrlmgr/controllers/cluster/cluster_controller.go Show resolved Hide resolved
pkg/ctrlmgr/controllers/cluster/cluster_controller.go Show resolved Hide resolved
pkg/multicluster/manager/multi_clutster_mgr.go Show resolved Hide resolved
pkg/multicluster/manager/multi_clutster_mgr.go Show resolved Hide resolved
pkg/multicluster/manager/multi_clutster_mgr.go Show resolved Hide resolved
pkg/warden/reporter/reporter.go Show resolved Hide resolved
JiahuiZhao11
JiahuiZhao11 reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@JiahuiZhao11 JiahuiZhao11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it delete cluster cr when retry timeout？

fusidamj
fusidamj approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@fusidamj fusidamj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhujf1989 zhujf1989 merged commit bed9d65 into main Aug 31, 2021
@zhujf1989 zhujf1989 deleted the bugfix/disconnect-cause-failure branch August 31, 2021 08:18
@weilaaa weilaaa linked an issue Oct 13, 2021 that may be closed by this pull request
[Bug] member cluster connect failed cause to kubecube startup failure #18
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fusidamj fusidamj fusidamj approved these changes

@JiahuiZhao11 JiahuiZhao11 JiahuiZhao11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] member cluster connect failed cause to kubecube startup failure
4 participants
@weilaaa @fusidamj @JiahuiZhao11 @zhujf1989