Add Custom Configuration spec for Kafka #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
raihankhan
requested changes
Jun 12, 2023
raihankhan
changed the title
raihankhan
force-pushed
the
add-config-secret
branch
from
07b5fdd
to
56d2ca1
Compare
raihankhan
previously approved these changes
Jun 19, 2023
tamalsaha
reviewed
Jun 19, 2023
apis/kubedb/v1alpha2/kafka_types.go
Outdated
| // ConfigSecret is an optional field to provide custom configuration file for database (i.e config.properties). | ||
| // If specified, this file will be used as configuration file otherwise default configuration file will be used. | ||
| // +optional | ||
| ConfigSecret *KafkaConfigSecret `json:"configSecret,omitempty"` |
There was a problem hiding this comment.
Use one secret
- config.properties
- broker.properties
- controller.properties
obaydullahmhs
force-pushed
the
add-config-secret
branch
from
56d2ca1
to
7ef614f
Compare
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
Signed-off-by: obaydullahmhs <obaydullah@appscode.com>
obaydullahmhs
force-pushed
the
add-config-secret
branch
from
7ef614f
to
bcf6aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: obaydullahmhs obaydullah@appscode.com
Fixes kubedb/project#897