Remove database versions from "all" category #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs hack/codegen.sh to do clean commits afterwards Signed-off-by: sh0rez <me@shorez.de>
Removes database and version objects from the "all" category See kubedb/project#375 Signed-off-by: sh0rez <me@shorez.de>
Ran hack/codegen.sh to reflect the changes introduced in f802621 Signed-off-by: sh0rez <me@shorez.de>
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=======================================
Coverage 54.44% 54.44%
=======================================
Files 6 6
Lines 281 281
=======================================
Hits 153 153
Misses 97 97
Partials 31 31Continue to review full report at Codecov.
|
|
@sh0rez Thank you for the PR. We will review it soon. |
tamalsaha
approved these changes
Dec 26, 2018
|
Thanks @sh0rez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the version objects of the individual databases from the
allcategory. IMHO they do not belong there, as they are cluster-wide resources and showing them on anallcall, which is namespaced (not cluster-wide), produces very verbose messages without any valuable information.Closes kubedb/project#375