[OSPP] EdgeMesh supports high availability architecture Design and Implementation #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
…p-circuit Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
…nodes Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
…cture Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
Signed-off-by: Poorunga <2744323@qq.com>
kubeedge-bot
added
the
kind/feature
Poorunga
force-pushed
the
feature-ha
branch
3 times, most recently
from
32b2b50
to
17336dc
Compare
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/libp2p/go-libp2p-core/peer" |
There was a problem hiding this comment.
This is not the import order recommended by go, please import in the following order:
- built-in packages
- third-party packages
- this project packages
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| "testing" | ||
| ) | ||
|
|
||
| /** |
There was a problem hiding this comment.
/**/ is not the function comment method recommended by go, please replace it with //
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
|
|
||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
/**/ is not the structure comment method recommended by go, please replace it with //, and comments and code are not related.
Poorunga
reviewed
Sep 19, 2022
| } | ||
|
|
||
| func TestAddCircuitAddrsToPeer(t *testing.T) { | ||
| want := "{12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg: [/ip4/5.5.5.5/tcp/9000/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg /ip4/5.5.5.5/tcp/9000/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/tcp/9000/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/udp/9000/quic/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/tcp/9000/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/udp/9000/quic/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/tcp/9000/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/udp/9000/quic/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/tcp/9000/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/tcp/9000/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/udp/9000/quic/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/tcp/9000/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/udp/9000/quic/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/tcp/9000/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/udp/9000/quic/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit]}" |
There was a problem hiding this comment.
A too long code, It is recommended to read this data from a file.
Poorunga
reviewed
Sep 19, 2022
| } | ||
| //test AddCircuitAddrsToPeer | ||
| AddCircuitAddrsToPeer(&relayPeer, relayList) | ||
| if err != nil { |
There was a problem hiding this comment.
this err is not return by AddCircuitAddrsToPeer(&relayPeer, relayList)
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| func TestAddCircuitAddrsToPeer(t *testing.T) { | ||
| want := "{12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg: [/ip4/5.5.5.5/tcp/9000/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg /ip4/5.5.5.5/tcp/9000/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/tcp/9000/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/udp/9000/quic/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/tcp/9000/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/udp/9000/quic/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/tcp/9000/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/udp/9000/quic/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/tcp/9000/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/5.5.5.5/udp/9000/quic/p2p/12D3KooWB5qVCMrMNLpBDfMu6o4dy6ci2UqDVsFVomcd2PfYVzfW/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/tcp/9000/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/6.6.6.6/udp/9000/quic/p2p/12D3KooWErZ4m27CEinjcnXNvem2KFUJUFRBcd9NdcWnYRqyr1Sn/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/tcp/9000/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/4.4.4.4/udp/9000/quic/p2p/12D3KooWSD4f5fZb5c9PQ6FPVd8Em4eKX3mRezcyqXSHUyomoy8S/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/tcp/9000/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit /ip4/8.8.8.8/udp/9000/quic/p2p/12D3KooWF3RB8SoMRZht7MDqF6GoipSPdFxVb9ESRLU7NuPX6ifH/p2p/12D3KooWQ4LGgA3djuvPt4Ao9YH2U39Yge5uzn3HwHXkDK23YDVg/p2p-circuit]}" | ||
| //节点列表 | ||
| var Nodes = []*testNode{ |
There was a problem hiding this comment.
Using exported variables inside functions is bad
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| } | ||
|
|
||
| func TestAppendMultiaddrs(t *testing.T) { | ||
| //want := |
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| } | ||
|
|
||
| func BenchmarkAddCircuitAddrsToPeer(b *testing.B) { | ||
| //节点列表 |
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| b.Errorf("AddAddress failed, err:%v", err) | ||
| } | ||
| b.Logf(relayPeer.String()) | ||
| //b.Logf("the final got : %s", relayPeer.String()) |
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
|
|
||
| // generate relayNode | ||
| priv, err := GenerateKeyPairWithString("MyNode") | ||
| assertEqualB(err, nil, b) |
There was a problem hiding this comment.
We don't have to use assertions in benchmark tests. How the function returns an error, just terminate the benchmark test directly.
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| assertEqual(err, nil, t) | ||
| out, err := peer.IDFromPrivateKey(key) | ||
| assertEqual(err, nil, t) | ||
| if ans := peer.Encode(out); !assertEqual(ans, c.wanted, t) { |
There was a problem hiding this comment.
Don't use expired functions: peer.Encode
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| return true | ||
| } | ||
|
|
||
| func assertTrue(t *testing.T, a bool) { |
Poorunga
reviewed
Sep 19, 2022
pkg/tunnel/util_test.go
Outdated
| key, err := GenerateKeyPairWithString(given) | ||
| b.StopTimer() | ||
| assertEqualB(err, nil, b) | ||
| out, err := peer.IDFromPrivateKey(key) |
There was a problem hiding this comment.
If you want to benchmark test, you must test a lot, refer to:
for i := 0; i < b.N; i++ {
_, err = peer.IDFromPrivateKey(key)
if err != nil {
b.Fatal(err)
}
}
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
Poorunga
force-pushed
the
feature-ha
branch
from
7941d99
to
625ec48
Compare
Signed-off-by: NKDYX <2374087322@qq.com>
Signed-off-by: NKDYX <2374087322@qq.com>
|
/lgtm |
|
@khalid-huang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khalid-jobs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
#353
#362
What this PR does / why we need it:
[OSPP] Code for EdgeMesh supports high availability architecture Design and Implementation
Main part of OSPP high availability (ha) feature. In this project we combined edgemesh-server and edgemesh-agent into a new structure--EdgeTunnel, which helps to relay and hole punch. The project contains new functions like Boostrap-Connection、mDNS-Discovery 、DHT-Discovery 、Relay-HeartBeat etc.