Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppletment spiderpool helm install switch #553

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented Mar 10, 2024

Add a switch to control the helm install for subchart spiderpool.
From the helm document, we just need to add a condition for subchart. And I already tested it in my cluster.

fix #550

Signed-off-by: Icarus9913 icaruswu66@qq.com

Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2024
@Icarus9913
Copy link
Contributor Author

@Poorunga
Copy link
Member

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poorunga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@kubeedge-bot kubeedge-bot merged commit ca8ebc2 into kubeedge:main Mar 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spiderpool not require default installation
3 participants